Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: content/browser/loader/navigation_url_loader_delegate.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from latest round of CR comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_DELEGATE_H_
6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_DELEGATE_H_ 6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_DELEGATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 21 matching lines...) Expand all
32 // made to the delegate. The response body is returned as a stream in 32 // made to the delegate. The response body is returned as a stream in
33 // |body_stream|. 33 // |body_stream|.
34 virtual void OnResponseStarted( 34 virtual void OnResponseStarted(
35 const scoped_refptr<ResourceResponse>& response, 35 const scoped_refptr<ResourceResponse>& response,
36 scoped_ptr<StreamHandle> body_stream) = 0; 36 scoped_ptr<StreamHandle> body_stream) = 0;
37 37
38 // Called if the request fails before receving a response. |net_error| is a 38 // Called if the request fails before receving a response. |net_error| is a
39 // network error code for the failure. 39 // network error code for the failure.
40 virtual void OnRequestFailed(int net_error) = 0; 40 virtual void OnRequestFailed(int net_error) = 0;
41 41
42 // Called when a begin navigation request is handled, right before the
davidben 2015/02/02 22:33:57 "Called when a begin navigation request is handled
davidben 2015/02/02 22:37:06 Sorry, never finished this comment. Perhaps: // C
carlosk 2015/02/03 11:00:04 Done.
43 // first potential network request happens, providing the |timestamp| when
44 // that happened in the IO thread.
45 virtual void NavigationRequested(base::TimeTicks timestamp) = 0;
nasko 2015/02/02 18:28:53 nit: OnNavigationRequested? mainly to match the na
carlosk 2015/02/03 11:00:04 Done.
46
42 protected: 47 protected:
43 NavigationURLLoaderDelegate() {} 48 NavigationURLLoaderDelegate() {}
44 virtual ~NavigationURLLoaderDelegate() {} 49 virtual ~NavigationURLLoaderDelegate() {}
45 50
46 private: 51 private:
47 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoaderDelegate); 52 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoaderDelegate);
48 }; 53 };
49 54
50 } // namespace content 55 } // namespace content
51 56
52 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_DELEGATE_H_ 57 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698