Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: public/web/WebFrameClient.h

Issue 874283003: Have WebFrameClient::suddenTerminationDisablerChanged return a boolean (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index c94d0f25416bdb12f23aa5c66af5a0bb63de5267..a921c138d56778838a8ee8f7f6e576618bd5bc9d 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -608,15 +608,14 @@ public:
// Sudden termination --------------------------------------------------
- // Called when an element preventing the sudden termination of the frame is
- // added or removed. |variation| is the number of elements added, removed if
- // it is negative. |type| is the type of element (BeforeUnload handler,
- // Unload handler).
+ // Called when elements preventing the sudden termination of the frame are
Charlie Reis 2015/01/28 20:45:02 nit: are -> become
clamy 2015/01/29 12:49:11 Done.
+ // present or stop being present. |type| is the type of element
+ // (BeforeUnload handler, Unload handler).
enum SuddenTerminationDisablerType {
BeforeUnloadHandler,
UnloadHandler,
};
- virtual void suddenTerminationDisablerChanged(int variation, SuddenTerminationDisablerType) { }
+ virtual void suddenTerminationDisablerChanged(bool present, SuddenTerminationDisablerType) { }
protected:
virtual ~WebFrameClient() { }
« Source/core/loader/FrameLoaderClient.h ('K') | « Source/web/FrameLoaderClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698