Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874283003: Have WebFrameClient::suddenTerminationDisablerChanged return a boolean (Closed)

Created:
5 years, 10 months ago by clamy
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Have WebFrameClient::suddenTerminationDisablerChanged return a boolean This CL makes WebFrameClient::suddenTerminationDisablerChanged return a boolean instead of the number of handlers removed/added. The function will now only be called when the BeforeUnload/Unload handlers for a frame go from being present to not being present and vice-versa. BUG=365039 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189190

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -40 lines) Patch
M Source/core/frame/LocalDOMWindow.cpp View 1 5 chunks +32 lines, -28 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
clamy
@japhet, creis: PTAL. This is the modification of the functions introduced by https://chromiumcodereview.appspot.com/861773003/ following the ...
5 years, 10 months ago (2015-01-26 16:36:07 UTC) #2
Nate Chapin
LGTM. Sorry I didn't think to ask about this when this callback was added.
5 years, 10 months ago (2015-01-26 18:29:11 UTC) #3
Charlie Reis
Sorry for the delay! Thanks for this update-- I think it will simplify the code ...
5 years, 10 months ago (2015-01-28 20:45:02 UTC) #4
clamy
Thanks! https://chromiumcodereview.appspot.com/874283003/diff/1/Source/core/loader/FrameLoaderClient.h File Source/core/loader/FrameLoaderClient.h (right): https://chromiumcodereview.appspot.com/874283003/diff/1/Source/core/loader/FrameLoaderClient.h#newcode232 Source/core/loader/FrameLoaderClient.h:232: // are present or stop being present. |type| ...
5 years, 10 months ago (2015-01-29 12:49:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874283003/20001
5 years, 10 months ago (2015-01-29 12:49:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 14:10:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189190

Powered by Google App Engine
This is Rietveld 408576698