scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json - Issue 873403002: Add support for cc_perftests and other non-telemetry gtest based tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

Issue 873403002: Add support for cc_perftests and other non-telemetry gtest based tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebase again + coverage. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/tryserver_chromium_linux_android_clang_dbg_recipe_fail_findbugs__with_patch__findbugs__without_patch_.json ('k') | scripts/slave/recipes/chromium_trybot_legacy.expected/analyze_finds_invalid_target.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

index bc6b5403c48affca82f75b3747fed96550a26f2f..7850a9b269fdb1c96bb412e10e6c3dd56ecee432 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

@@ -129,7 +129,7 @@

"--paths",

"{\"build\": \"[BUILD]\", \"checkout\": \"[SLAVE_BUILD]\\\\src\"}",

"--properties",

- "{\"buildername\": \"win_chromium_rel_ng\", \"buildnumber\": 571, \"slavename\": \"TestSlavename\"}"

+ "{\"buildername\": \"win_chromium_rel_ng\", \"buildnumber\": 571, \"mastername\": \"tryserver.chromium.win\", \"slavename\": \"TestSlavename\", \"target_platform\": \"win\"}"

"name": "get compile targets for scripts",

"~followup_annotations": [