Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 873403002: Add support for cc_perftests and other non-telemetry gtest based tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 8febca334aeb6308e7f9e2fa738c9e9768bde1b8..7b48260801c0a409822e9b55a9758660a011e1e2 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -471,6 +471,29 @@ class AndroidApi(recipe_api.RecipeApi):
if failures:
raise self.m.step.StepFailure('sharded perf tests failed %s' % failures)
+ def run_other_gtests(self, perf_tests, perf_id=None):
+ failures = []
+ for test_name, test_data in sorted(perf_tests.iteritems()):
+ test_name = str(test_name) # un-unicode
+ test_suite = str(test_data['cmd']) # un-unicode
ghost stip (do not use) 2015/01/27 01:02:02 nit: # Comments are a capitalized statement ending
+ dashboard_id = str(test_data['perf_dashboard_id'])
+ annotate = self.m.chromium.get_annotate_by_test_name(test_name)
+
+ try:
+ self.m.chromium.runtest(
+ self.c.test_runner,
+ ['gtest', '--release', '--suite', test_suite, '--verbose'],
+ name=test_name,
+ perf_dashboard_id=dashboard_id,
+ annotate=annotate,
+ results_url='https://chromeperf.appspot.com',
+ perf_id=perf_id,
+ env=self.m.chromium.get_env())
+ except self.m.step.StepFailure as f:
+ failures.append(f)
+ if failures:
+ raise self.m.step.StepFailure('non-telemetry tests failed %s' % failures)
+
@recipe_api.non_step
def get_instrumentation_suite(self, suite_name):
for suite in INSTRUMENTATION_TESTS:

Powered by Google App Engine
This is Rietveld 408576698