Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: content/common/navigation_params.h

Issue 872473003: PlzNavigate: Remove the RequestNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits + fix compilation error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index b23847c3cbf4e7887da70bd52d6442dc6179d59e..757d1a7fcc32f93c19ebb7f782badf670381a585 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -68,24 +68,27 @@ struct CONTENT_EXPORT CommonNavigationParams {
FrameMsg_UILoadMetricsReportType::Value report_type;
};
-// Used by FrameMsg_Navigate.
-// PlzNavigate: sent to the renderer when requesting a navigation.
-struct CONTENT_EXPORT RequestNavigationParams {
- RequestNavigationParams();
- RequestNavigationParams(bool is_post,
- const std::string& extra_headers,
- const base::RefCountedMemory* post_data);
- ~RequestNavigationParams();
-
- // Whether the navigation is a POST request (as opposed to a GET).
- bool is_post;
-
- // Extra headers (separated by \n) to send during the request.
- std::string extra_headers;
-
- // If is_post is true, holds the post_data information from browser. Empty
- // otherwise.
- std::vector<unsigned char> browser_initiated_post_data;
+// PlzNavigate: parameters needed to start a navigation on the IO thread.
+struct CONTENT_EXPORT BeginNavigationParams {
+ // TODO(clamy): See if it is possible to reuse this in
+ // ResourceMsg_Request_Params.
+ BeginNavigationParams();
+ BeginNavigationParams(std::string method,
+ std::string headers,
+ int load_flags,
+ bool has_user_gesture);
+
+ // The request method: GET, POST, etc.
+ std::string method;
+
+ // Additional HTTP request headers.
+ std::string headers;
+
+ // net::URLRequest load flags (net::LOAD_NORMAL) by default).
+ int load_flags;
+
+ // True if the request was user initiated.
+ bool has_user_gesture;
};
// Used by FrameMsg_Navigate.
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698