Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: content/browser/frame_host/navigator.h

Issue 872473003: PlzNavigate: Remove the RequestNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits + fix compilation error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_request_info.cc ('k') | content/browser/frame_host/navigator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index e56335ad5a77458cfb06b1407eb362149370cf10..a69dfdf81288f65877c0a45eec14a44e8c425738 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -28,7 +28,9 @@ class NavigationEntryImpl;
class NavigationRequest;
class NavigatorDelegate;
class RenderFrameHostImpl;
+class ResourceRequestBody;
class StreamHandle;
+struct BeginNavigationParams;
struct CommonNavigationParams;
struct ResourceResponse;
@@ -116,15 +118,22 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
bool should_replace_current_entry,
bool user_gesture) {}
- // PlzNavigate: Used to start a navigation. OnBeginNavigation is called
- // directly by RequestNavigation when there is no live renderer. Otherwise, it
- // is called following a BeginNavigation IPC from the renderer (which in
- // browser-initiated navigation also happens after RequestNavigation has been
- // called).
+ // PlzNavigate
+ // Called after receiving a BeforeUnloadACK IPC from the renderer. If
+ // |frame_tree_node| has a NavigationRequest waiting for the renderer
+ // response, then the request is either started or canceled, depending on the
+ // value of |proceed|.
+ virtual void OnBeforeUnloadACK(FrameTreeNode* frame_tree_node,
+ bool proceed) {}
+
+ // PlzNavigate
+ // Used to start a new renderer-initiated navigation, following a
+ // BeginNavigation IPC from the renderer.
virtual void OnBeginNavigation(
FrameTreeNode* frame_tree_node,
- const FrameHostMsg_BeginNavigation_Params& params,
- const CommonNavigationParams& common_params) {}
+ const CommonNavigationParams& common_params,
+ const BeginNavigationParams& begin_params,
+ scoped_refptr<ResourceRequestBody> body);
// PlzNavigate
// Signal |render_frame_host| that a navigation is ready to commit (the
« no previous file with comments | « content/browser/frame_host/navigation_request_info.cc ('k') | content/browser/frame_host/navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698