Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 872473003: PlzNavigate: Remove the RequestNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 8fa21dc458b1cac2fe80adfc54126e31a35d352e..f413c2b51d1c28e897d09271360c7db1f5fb4f80 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -461,18 +461,6 @@ void UpdateFrameNavigationTiming(WebFrame* frame,
}
// PlzNavigate
-FrameHostMsg_BeginNavigation_Params MakeBeginNavigationParams(
- blink::WebURLRequest* request) {
- FrameHostMsg_BeginNavigation_Params params;
- params.method = request->httpMethod().latin1();
- params.headers = GetWebURLRequestHeaders(*request);
- params.load_flags = GetLoadFlagsForWebURLRequest(*request);
- params.request_body = GetRequestBodyForWebURLRequest(*request);
- params.has_user_gesture = request->hasUserGesture();
- return params;
-}
-
-// PlzNavigate
CommonNavigationParams MakeCommonNavigationParams(
blink::WebURLRequest* request) {
const RequestExtraData kEmptyData;
@@ -1037,7 +1025,6 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(FrameMsg_SetAccessibilityMode,
OnSetAccessibilityMode)
IPC_MESSAGE_HANDLER(FrameMsg_DisownOpener, OnDisownOpener)
- IPC_MESSAGE_HANDLER(FrameMsg_RequestNavigation, OnRequestNavigation)
IPC_MESSAGE_HANDLER(FrameMsg_CommitNavigation, OnCommitNavigation)
#if defined(OS_ANDROID)
IPC_MESSAGE_HANDLER(FrameMsg_SelectPopupMenuItems, OnSelectPopupMenuItems)
@@ -3855,20 +3842,6 @@ void RenderFrameImpl::FocusedNodeChangedForAccessibility(const WebNode& node) {
}
// PlzNavigate
-void RenderFrameImpl::OnRequestNavigation(
- const CommonNavigationParams& common_params,
- const RequestNavigationParams& request_params) {
- CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableBrowserSideNavigation));
- WebURLRequest request =
- CreateURLRequestForNavigation(common_params,
- request_params,
- scoped_ptr<StreamOverrideParameters>(),
- frame_->isViewSourceModeEnabled());
- BeginNavigation(&request);
-}
-
-// PlzNavigate
void RenderFrameImpl::OnCommitNavigation(
const ResourceResponseHead& response,
const GURL& stream_url,
@@ -4373,9 +4346,13 @@ void RenderFrameImpl::BeginNavigation(blink::WebURLRequest* request) {
// TODO(clamy): Same-document navigations should not be sent back to the
// browser.
// TODO(clamy): Data urls should not be sent back to the browser either.
- Send(new FrameHostMsg_BeginNavigation(routing_id_,
- MakeBeginNavigationParams(request),
- MakeCommonNavigationParams(request)));
+ Send(new FrameHostMsg_BeginNavigation(
+ routing_id_, MakeCommonNavigationParams(request),
+ BeginNavigationParams(request->httpMethod().latin1(),
+ GetWebURLRequestHeaders(*request),
+ GetLoadFlagsForWebURLRequest(*request),
+ request->hasUserGesture()),
+ GetRequestBodyForWebURLRequest(*request)));
}
GURL RenderFrameImpl::GetLoadingUrl() const {

Powered by Google App Engine
This is Rietveld 408576698