Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: content/browser/loader/navigation_url_loader.h

Issue 872473003: PlzNavigate: Remove the RequestNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits + fix compilation error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_ 5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_
6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_ 6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 class BrowserContext; 15 class BrowserContext;
16 class NavigationURLLoaderDelegate; 16 class NavigationURLLoaderDelegate;
17 class NavigationURLLoaderFactory; 17 class NavigationURLLoaderFactory;
18 class ResourceRequestBody;
19 struct CommonNavigationParams; 18 struct CommonNavigationParams;
20 struct NavigationRequestInfo; 19 struct NavigationRequestInfo;
21 20
22 // PlzNavigate: The navigation logic's UI thread entry point into the resource 21 // PlzNavigate: The navigation logic's UI thread entry point into the resource
23 // loading stack. It exposes an interface to control the request prior to 22 // loading stack. It exposes an interface to control the request prior to
24 // receiving the response. If the NavigationURLLoader is destroyed before 23 // receiving the response. If the NavigationURLLoader is destroyed before
25 // OnResponseStarted is called, the request is aborted. 24 // OnResponseStarted is called, the request is aborted.
26 class CONTENT_EXPORT NavigationURLLoader { 25 class CONTENT_EXPORT NavigationURLLoader {
27 public: 26 public:
28 // Creates a NavigationURLLoader. The caller is responsible for ensuring that 27 // Creates a NavigationURLLoader. The caller is responsible for ensuring that
29 // |delegate| outlives the loader. |request_body| must not be accessed on the 28 // |delegate| outlives the loader. |request_body| must not be accessed on the
30 // UI thread after this point. 29 // UI thread after this point.
31 // 30 //
32 // TODO(davidben): When navigation is disentangled from the loader, the 31 // TODO(davidben): When navigation is disentangled from the loader, the
33 // request parameters should not come in as a navigation-specific 32 // request parameters should not come in as a navigation-specific
34 // structure. Information like has_user_gesture and 33 // structure. Information like has_user_gesture and
35 // should_replace_current_entry shouldn't be needed at this layer. 34 // should_replace_current_entry shouldn't be needed at this layer.
36 static scoped_ptr<NavigationURLLoader> Create( 35 static scoped_ptr<NavigationURLLoader> Create(
37 BrowserContext* browser_context, 36 BrowserContext* browser_context,
38 int64 frame_tree_node_id, 37 int64 frame_tree_node_id,
39 const CommonNavigationParams& common_params,
40 scoped_ptr<NavigationRequestInfo> request_info, 38 scoped_ptr<NavigationRequestInfo> request_info,
41 ResourceRequestBody* request_body,
42 NavigationURLLoaderDelegate* delegate); 39 NavigationURLLoaderDelegate* delegate);
43 40
44 // For testing purposes; sets the factory for use in testing. 41 // For testing purposes; sets the factory for use in testing.
45 static void SetFactoryForTesting(NavigationURLLoaderFactory* factory); 42 static void SetFactoryForTesting(NavigationURLLoaderFactory* factory);
46 43
47 virtual ~NavigationURLLoader() {} 44 virtual ~NavigationURLLoader() {}
48 45
49 // Called in response to OnRequestRedirected to continue processing the 46 // Called in response to OnRequestRedirected to continue processing the
50 // request. 47 // request.
51 virtual void FollowRedirect() = 0; 48 virtual void FollowRedirect() = 0;
52 49
53 protected: 50 protected:
54 NavigationURLLoader() {} 51 NavigationURLLoader() {}
55 52
56 private: 53 private:
57 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoader); 54 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoader);
58 }; 55 };
59 56
60 } // namespace content 57 } // namespace content
61 58
62 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_ 59 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/loader/navigation_url_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698