PlzNavigate: Remove the RequestNavigation IPC

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 51 matching lines @@
   // Timestamp of the user input event that triggered this navigation. Empty if
   // the navigation was not triggered by clicking on a link or by receiving an
   // intent on Android.
   base::TimeTicks ui_timestamp;
 
   // The report type to be used when recording the metric using |ui_timestamp|.
   FrameMsg_UILoadMetricsReportType::Value report_type;
 };
 
 // Used by FrameMsg_Navigate.
-// PlzNavigate: sent to the renderer when requesting a navigation.
 struct CONTENT_EXPORT RequestNavigationParams {

[nasko, 2015/02/02 21:17:43]

Do we still need this struct if we have removed the IPC?

[clamy, 2015/02/03 16:17:10]

Done.

   RequestNavigationParams();
   RequestNavigationParams(bool is_post,
                           const std::string& extra_headers,
                           const base::RefCountedMemory* post_data);
   ~RequestNavigationParams();
 
   // Whether the navigation is a POST request (as opposed to a GET).
   bool is_post;
 
   // Extra headers (separated by \n) to send during the request.
   std::string extra_headers;
 
   // If is_post is true, holds the post_data information from browser. Empty
   // otherwise.
   std::vector<unsigned char> browser_initiated_post_data;
 };
 
+// PlzNavigate: parameters needed to start a navigation on the IO thread.
+struct CONTENT_EXPORT BeginNavigationParams {
+  // TODO(clamy): See if it is possible to reuse this in
+  // ResourceMsg_Request_Params.
+  BeginNavigationParams();

[nasko, 2015/02/02 21:17:43]

Should we allow a parameterless constructor? The current version of this
constructor doesn't initialize defaults for method or headers.

[clamy, 2015/02/03 16:17:10]

Actually it seems we need one to pass this struct as an IPC parameter.

+  BeginNavigationParams(std::string method,
+                        std::string headers,
+                        int load_flags,
+                        bool has_user_gesture);
+
+  // The request method: GET, POST, etc.
+  std::string method;
+
+  // Additional HTTP request headers.
+  std::string headers;
+
+  // net::URLRequest load flags (net::LOAD_NORMAL) by default).
+  int load_flags;
+
+  // True if the request was user initiated.
+  bool has_user_gesture;
+};
+
 // Used by FrameMsg_Navigate.
 // PlzNavigate: sent to the renderer when the navigation is ready to commit.
 struct CONTENT_EXPORT CommitNavigationParams {
   CommitNavigationParams();
   CommitNavigationParams(const PageState& page_state,
                          bool is_overriding_user_agent,
                          base::TimeTicks navigation_start);
   ~CommitNavigationParams();
 
   // Opaque history state (received by ViewHostMsg_UpdateState).
   PageState page_state;
 
   // Whether or not the user agent override string should be used.
   bool is_overriding_user_agent;
 
   // The navigationStart time to expose through the Navigation Timing API to JS.
   base::TimeTicks browser_navigation_start;
 
   // TODO(clamy): Move the redirect chain here.
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_