content/ppapi_plugin/ppapi_thread.cc - Issue 868253011: Make chrome.exe built with ASan/Win work with sandbox enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 868253011: Make chrome.exe built with ASan/Win work with sandbox enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more EXPECT turned into ASSERT Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/ppapi_plugin/ppapi_thread.cc

diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc

index 6d77afe546f494f9e220b5480421833016773bb3..a6181790cb1469bcf837ffefb83103b1223d4bd7 100644

--- a/content/ppapi_plugin/ppapi_thread.cc

+++ b/content/ppapi_plugin/ppapi_thread.cc

@@ -417,6 +417,12 @@ void PpapiThread::OnLoadPlugin(const base::FilePath& path,

WarmupWindowsLocales(permissions);

+#if defined(ADDRESS_SANITIZER)

+ // Bind and leak dbghelp.dll before the token is lowered, otherwise

+ // AddressSanitizer will crash when trying to symbolize a report.

+ LoadLibraryA("dbghelp.dll");

+#endif

g_target_services->LowerToken();

}

#endif

« no previous file with comments | « content/gpu/gpu_main.cc ('k') | content/renderer/renderer_main_platform_delegate_win.cc » ('j') | sandbox/win/src/address_sanitizer_test.cc » ('J')