sandbox/linux/services/credentials_unittest.cc - Issue 868233011: Start all children in their own PID namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/services/credentials_unittest.cc

Issue 868233011: Start all children in their own PID namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add InstallDefaultTerminationSignalHandlers. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sandbox/linux/services/credentials.h ('K') | « sandbox/linux/services/credentials.cc ('k') | sandbox/linux/services/namespace_sandbox.h » ('j') | sandbox/linux/services/namespace_sandbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/linux/services/credentials_unittest.cc

diff --git a/sandbox/linux/services/credentials_unittest.cc b/sandbox/linux/services/credentials_unittest.cc

index db19f6fee561073c1dc7a0f0ba7dfc29b91abd65..191a0a958feb6101686a6e546106bd7e07b8b4cb 100644

--- a/sandbox/linux/services/credentials_unittest.cc

+++ b/sandbox/linux/services/credentials_unittest.cc

@@ -177,16 +177,17 @@ SANDBOX_TEST(Credentials, SetCapabilities) {

base::ScopedFD proc_fd(ProcUtil::OpenProc());

- CHECK(Credentials::HasCapability(LinuxCapability::kCapSysAdmin));

- CHECK(Credentials::HasCapability(LinuxCapability::kCapSysChroot));

+ CHECK(Credentials::HasCapability(Credentials::Capability::kCapSysAdmin));

+ CHECK(Credentials::HasCapability(Credentials::Capability::kCapSysChroot));

- const std::vector<LinuxCapability> caps = {LinuxCapability::kCapSysChroot};

+ std::vector<Credentials::Capability> caps;

+ caps.push_back(Credentials::Capability::kCapSysChroot);

CHECK(Credentials::SetCapabilities(proc_fd.get(), caps));

- CHECK(!Credentials::HasCapability(LinuxCapability::kCapSysAdmin));

- CHECK(Credentials::HasCapability(LinuxCapability::kCapSysChroot));

+ CHECK(!Credentials::HasCapability(Credentials::Capability::kCapSysAdmin));

+ CHECK(Credentials::HasCapability(Credentials::Capability::kCapSysChroot));

- const std::vector<LinuxCapability> no_caps;

+ const std::vector<Credentials::Capability> no_caps;

CHECK(Credentials::SetCapabilities(proc_fd.get(), no_caps));

CHECK(!Credentials::HasAnyCapability());

}

@@ -198,10 +199,11 @@ SANDBOX_TEST(Credentials, SetCapabilitiesAndChroot) {

base::ScopedFD proc_fd(ProcUtil::OpenProc());

- CHECK(Credentials::HasCapability(LinuxCapability::kCapSysChroot));

+ CHECK(Credentials::HasCapability(Credentials::Capability::kCapSysChroot));

PCHECK(chroot("/") == 0);

- const std::vector<LinuxCapability> caps = {LinuxCapability::kCapSysChroot};

+ std::vector<Credentials::Capability> caps;

+ caps.push_back(Credentials::Capability::kCapSysChroot);

CHECK(Credentials::SetCapabilities(proc_fd.get(), caps));

PCHECK(chroot("/") == 0);

@@ -216,7 +218,8 @@ SANDBOX_TEST(Credentials, SetCapabilitiesMatchesLibCap2) {

base::ScopedFD proc_fd(ProcUtil::OpenProc());

- const std::vector<LinuxCapability> caps = {LinuxCapability::kCapSysChroot};

+ std::vector<Credentials::Capability> caps;

+ caps.push_back(Credentials::Capability::kCapSysChroot);

CHECK(Credentials::SetCapabilities(proc_fd.get(), caps));

ScopedCap actual_cap(cap_get_proc());