Start all children in their own PID namespace.

sandbox/linux/services/namespace_sandbox_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/services/namespace_sandbox.h"
 
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
@@ skipping 100 matching lines @@
   int exit_code = kDummyExitCode;
   CHECK(process.WaitForExit(&exit_code));
   CHECK_EQ(0, exit_code);
   return 0;
 }
 
 TEST_F(NamespaceSandboxTest, NestedNamespaceSandbox) {
   TestProc("NestedNamespaceSandbox");
 }
 
+const int kNormalExitCode = 0;
+const int kSignalTerminationExitCode = 255;
+
+SANDBOX_TEST(ForkInNewPidNamespace, BasicUsage) {
+  if (!Credentials::CanCreateProcessInNewUserNS()) {
+    return;
+  }
+
+  CHECK(sandbox::Credentials::MoveToNewUserNS());
+  const pid_t pid = NamespaceSandbox::ForkInNewPidNamespace(true);
+  CHECK_GE(pid, 0);
+
+  if (pid == 0) {
+    CHECK_EQ(1, getpid());

[jln (very slow on Chromium), 2015/03/25 23:47:50]

I don't like the implicit dependency on kNormalExitCode being different from
what CHECK would exit with.

Maybe add a test for CHECK(false) exiting with something else than
kNormalExitCode?

[rickyz (no longer on Chrome), 2015/03/26 00:09:37]

Sure, I added the test (and found out in the process that the stack trace from
the CHECK failure would cause the test to fail if we hit it)

[jln (very slow on Chromium), 2015/03/26 00:49:47]

Indeed, but that's a SANDBOX_TEST feature FYI :)

+    CHECK(!Credentials::HasAnyCapability());
+    _exit(kNormalExitCode);
+  }
+
+  int status;
+  PCHECK(waitpid(pid, &status, 0) == pid);
+  CHECK(WIFEXITED(status));
+  CHECK_EQ(kNormalExitCode, WEXITSTATUS(status));
+}
+
+SANDBOX_TEST(ForkInNewPidNamespace, ExitWithSignal) {
+  if (!Credentials::CanCreateProcessInNewUserNS()) {
+    return;
+  }
+
+  CHECK(sandbox::Credentials::MoveToNewUserNS());
+  const pid_t pid = NamespaceSandbox::ForkInNewPidNamespace(true);

[jln (very slow on Chromium), 2015/03/25 23:47:50]

/* drop_capabilities_in_child */

[rickyz (no longer on Chrome), 2015/03/26 00:09:37]

Done.

+  CHECK_GE(pid, 0);
+
+  if (pid == 0) {
+    CHECK_EQ(1, getpid());
+    CHECK(!Credentials::HasAnyCapability());
+    NamespaceSandbox::InstallTerminationSignalHandler(
+        SIGTERM, kSignalTerminationExitCode);
+    while (true) {
+      raise(SIGTERM);
+    }
+  }
+
+  int status;
+  PCHECK(waitpid(pid, &status, 0) == pid);
+  CHECK(WIFEXITED(status));
+  CHECK_EQ(kSignalTerminationExitCode, WEXITSTATUS(status));
+}
+
 }  // namespace
 
 }  // namespace sandbox