Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/platform_util_linux.cc

Issue 864163003: Rename base::Process::pid() to Pid() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/platform_util.h" 5 #include "chrome/browser/platform_util.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/process/kill.h" 9 #include "base/process/kill.h"
10 #include "base/process/launch.h" 10 #include "base/process/launch.h"
(...skipping 21 matching lines...) Expand all
32 // In Google Chrome, we do not let GNOME's bug-buddy intercept our crashes. 32 // In Google Chrome, we do not let GNOME's bug-buddy intercept our crashes.
33 // However, we do not want this environment variable to propagate to external 33 // However, we do not want this environment variable to propagate to external
34 // applications. See http://crbug.com/24120 34 // applications. See http://crbug.com/24120
35 char* disable_gnome_bug_buddy = getenv("GNOME_DISABLE_CRASH_DIALOG"); 35 char* disable_gnome_bug_buddy = getenv("GNOME_DISABLE_CRASH_DIALOG");
36 if (disable_gnome_bug_buddy && 36 if (disable_gnome_bug_buddy &&
37 disable_gnome_bug_buddy == std::string("SET_BY_GOOGLE_CHROME")) 37 disable_gnome_bug_buddy == std::string("SET_BY_GOOGLE_CHROME"))
38 options.environ["GNOME_DISABLE_CRASH_DIALOG"] = std::string(); 38 options.environ["GNOME_DISABLE_CRASH_DIALOG"] = std::string();
39 39
40 base::Process process = base::LaunchProcess(argv, options); 40 base::Process process = base::LaunchProcess(argv, options);
41 if (process.IsValid()) 41 if (process.IsValid())
42 base::EnsureProcessGetsReaped(process.pid()); 42 base::EnsureProcessGetsReaped(process.Pid());
43 } 43 }
44 44
45 void XDGOpen(const std::string& path) { 45 void XDGOpen(const std::string& path) {
46 XDGUtil("xdg-open", path); 46 XDGUtil("xdg-open", path);
47 } 47 }
48 48
49 void XDGEmail(const std::string& email) { 49 void XDGEmail(const std::string& email) {
50 XDGUtil("xdg-email", email); 50 XDGUtil("xdg-email", email);
51 } 51 }
52 52
(...skipping 26 matching lines...) Expand all
79 79
80 void OpenExternal(Profile* profile, const GURL& url) { 80 void OpenExternal(Profile* profile, const GURL& url) {
81 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 81 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
82 if (url.SchemeIs("mailto")) 82 if (url.SchemeIs("mailto"))
83 XDGEmail(url.spec()); 83 XDGEmail(url.spec());
84 else 84 else
85 XDGOpen(url.spec()); 85 XDGOpen(url.spec());
86 } 86 }
87 87
88 } // namespace platform_util 88 } // namespace platform_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698