Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 861773003: Inform the WebFrameClient of BeforeUnload/Unload handlers (Closed)

Created:
5 years, 11 months ago by clamy
Modified:
5 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Inform the WebFrameClient of BeforeUnload/Unload handlers This CL makes it possible for a WebFrameClient to be made aware of the registration and unregistration of BeforeUnload handlers. This is the first step in refactoring the sudden termination API, with the following chromium-side patch https://chromiumcodereview.appspot.com/857213003/. BUG=365039 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188805

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 8

Patch Set 3 : Addressed Nate's comments #

Total comments: 2

Patch Set 4 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M Source/core/frame/LocalDOMWindow.cpp View 1 2 3 6 chunks +26 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M public/platform/Platform.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
clamy
@creis, nasko, japhet: PTAL. This is the first patch to clean up the sudden termination ...
5 years, 11 months ago (2015-01-20 16:47:02 UTC) #2
Nate Chapin
Nit: BeofreUnload->BeforeUnload in change description. https://codereview.chromium.org/861773003/diff/20001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/861773003/diff/20001/Source/core/frame/LocalDOMWindow.cpp#newcode246 Source/core/frame/LocalDOMWindow.cpp:246: enableSuddenTermination(); Will we eventually ...
5 years, 11 months ago (2015-01-20 18:46:49 UTC) #3
clamy
Thanks! https://chromiumcodereview.appspot.com/861773003/diff/20001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (right): https://chromiumcodereview.appspot.com/861773003/diff/20001/Source/core/frame/LocalDOMWindow.cpp#newcode246 Source/core/frame/LocalDOMWindow.cpp:246: enableSuddenTermination(); On 2015/01/20 18:46:49, Nate Chapin wrote: > ...
5 years, 11 months ago (2015-01-21 13:46:32 UTC) #4
Nate Chapin
LGTM https://codereview.chromium.org/861773003/diff/20001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/861773003/diff/20001/Source/core/frame/LocalDOMWindow.cpp#newcode246 Source/core/frame/LocalDOMWindow.cpp:246: enableSuddenTermination(); On 2015/01/21 13:46:31, clamy wrote: > On ...
5 years, 11 months ago (2015-01-21 19:51:42 UTC) #5
Charlie Reis
Rubber stamp LGTM (as non-owner). That's unfortunate about DOM storage callbacks being per-process, but we ...
5 years, 11 months ago (2015-01-21 23:09:25 UTC) #6
clamy
Thanks! https://chromiumcodereview.appspot.com/861773003/diff/40001/public/platform/Platform.h File public/platform/Platform.h (right): https://chromiumcodereview.appspot.com/861773003/diff/40001/public/platform/Platform.h#newcode401 public/platform/Platform.h:401: // is preferable to disable sudden on a ...
5 years, 11 months ago (2015-01-22 10:34:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861773003/60001
5 years, 11 months ago (2015-01-22 10:35:20 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 11:45:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188805

Powered by Google App Engine
This is Rietveld 408576698