Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: components/browser_watcher/exit_code_watcher_win_unittest.cc

Issue 859413003: Remove uses of CloseProcessHandle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (revert watcher client changes) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/process_posix.cc ('k') | components/browser_watcher/watcher_client_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/exit_code_watcher_win_unittest.cc
diff --git a/components/browser_watcher/exit_code_watcher_win_unittest.cc b/components/browser_watcher/exit_code_watcher_win_unittest.cc
index a5ba33372acf13f7a1eeacd2f0d546f15c5c505b..3e1728c1513aeb086ad8a87f4aa668e996718d63 100644
--- a/components/browser_watcher/exit_code_watcher_win_unittest.cc
+++ b/components/browser_watcher/exit_code_watcher_win_unittest.cc
@@ -77,10 +77,7 @@ class ExitCodeWatcherTest : public testing::Test {
static const int kExitCode = 0xCAFEBABE;
- ExitCodeWatcherTest() :
- cmd_line_(base::CommandLine::NO_PROGRAM),
- process_(base::kNullProcessHandle) {
- }
+ ExitCodeWatcherTest() : cmd_line_(base::CommandLine::NO_PROGRAM) {}
virtual void SetUp() override {
Super::SetUp();
@@ -88,15 +85,6 @@ class ExitCodeWatcherTest : public testing::Test {
override_manager_.OverrideRegistry(HKEY_CURRENT_USER);
}
- virtual void TearDown() override {
- if (process_ != base::kNullProcessHandle) {
- base::CloseProcessHandle(process_);
- process_ = base::kNullProcessHandle;
- }
-
- Super::TearDown();
- }
-
base::Process OpenSelfWithAccess(uint32 access) {
return base::Process::OpenWithAccess(base::GetCurrentProcId(), access);
}
@@ -121,7 +109,6 @@ class ExitCodeWatcherTest : public testing::Test {
protected:
base::CommandLine cmd_line_;
- base::ProcessHandle process_;
registry_util::RegistryOverrideManager override_manager_;
};
« no previous file with comments | « base/process/process_posix.cc ('k') | components/browser_watcher/watcher_client_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698