Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: base/base_paths_mac.mm

Issue 8585029: Make GetWebKitRootDirFilePath smarter about where the WebKit root is relative to the chromium root (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base_paths_mac.mm
diff --git a/base/base_paths_mac.mm b/base/base_paths_mac.mm
index aed3ea8e3eb787de288e1c702fd120e752be91d8..69f3a1c15778b590c46958680e5c5388c0938655 100644
--- a/base/base_paths_mac.mm
+++ b/base/base_paths_mac.mm
@@ -17,6 +17,9 @@
#include "base/string_util.h"
namespace {
+// The name of this file relative to the source root. This is used for checking
+// that the source checkout is in the correct place.
+static const char kThisSourceFile[] = "base/base_paths_mac.mm";
void GetNSExecutablePath(FilePath* path) {
DCHECK(path);
@@ -78,6 +81,13 @@ bool PathProviderMac(int key, FilePath* result) {
// src/xcodebuild/{Debug|Release}/base_unittests
*result = result->DirName().DirName();
}
+ // In a case of a WebKit-only checkout, using make instead of
+ // xcodebuild, we should return <root of
+ // checkout>/Source/WebKit/chromium.
+ // FIXME(thakis): try to move the xcodebuild directory up two levels.
Nico 2012/01/19 16:06:49 s/FIXME/TODO
jochen (gone - plz use gerrit) 2012/01/19 16:31:20 Done.
+ // http://crbug.com/110455
+ if (!file_util::PathExists(result->Append(kThisSourceFile)))
+ *result = result->Append("Source/WebKit/chromium");
Nico 2012/01/19 16:06:49 CHECK(file_util::PAthExists(result->Append(kThisSo
jochen (gone - plz use gerrit) 2012/01/19 16:31:20 Done.
return true;
}
default:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698