Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 857043002: <webview>: Cleanup (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GuestView: Cleanup This CL uses the new C++11 auto keyword to improve readability of GuestView code. There are two main ways auto is being used in this CL: 1. Iterators. It is verbose to specify the type of an iterator that's fairly self-evident, so we avoid that now. 2. *::From* calls. Some objects are accessible via IDs or some other key. It is self-evident the return type in this case and so it is reasonable to use auto here as well. BUG=none Committed: https://crrev.com/4a5c599932ad9f004ad8c62bf71fc812b994797f Cr-Commit-Position: refs/heads/master@{#312242}

Patch Set 1 #

Patch Set 2 : More use of auto #

Patch Set 3 : More cleanup #

Total comments: 2

Patch Set 4 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -71 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 5 chunks +5 lines, -10 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 5 chunks +15 lines, -18 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.cc View 1 8 chunks +17 lines, -26 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 9 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Fady Samuel
5 years, 11 months ago (2015-01-20 15:31:56 UTC) #2
lazyboy
lgtm https://chromiumcodereview.appspot.com/857043002/diff/40001/extensions/browser/guest_view/web_view/web_view_guest.cc File extensions/browser/guest_view/web_view/web_view_guest.cc (right): https://chromiumcodereview.appspot.com/857043002/diff/40001/extensions/browser/guest_view/web_view/web_view_guest.cc#newcode264 extensions/browser/guest_view/web_view/web_view_guest.cc:264: auto guest_site_instance = This one doesn't fall within ...
5 years, 11 months ago (2015-01-20 18:20:35 UTC) #3
Fady Samuel
Addressed comment. CQ'ing now. https://chromiumcodereview.appspot.com/857043002/diff/40001/extensions/browser/guest_view/web_view/web_view_guest.cc File extensions/browser/guest_view/web_view/web_view_guest.cc (right): https://chromiumcodereview.appspot.com/857043002/diff/40001/extensions/browser/guest_view/web_view/web_view_guest.cc#newcode264 extensions/browser/guest_view/web_view/web_view_guest.cc:264: auto guest_site_instance = On 2015/01/20 ...
5 years, 11 months ago (2015-01-20 18:28:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857043002/60001
5 years, 11 months ago (2015-01-20 18:30:08 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-20 19:22:22 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 19:23:28 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4a5c599932ad9f004ad8c62bf71fc812b994797f
Cr-Commit-Position: refs/heads/master@{#312242}

Powered by Google App Engine
This is Rietveld 408576698