Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 85333004: Use isolate schedule immediate. Update embedder. (Closed)

Created:
7 years ago by floitsch
Modified:
7 years ago
Reviewers:
vsm
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reupload because of error 500. #

Patch Set 3 : Reupload because of error 500. #

Patch Set 4 : Adapt after change to VM. #

Patch Set 5 : Reupload after error 500 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
Source/bindings/dart/DartController.cpp View 1 2 3 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
Make scheduleMicrotask work in isolates. Depends on https://chromiumcodereview.appspot.com/79243002/
7 years ago (2013-11-25 15:14:35 UTC) #1
vsm
lgtm
7 years ago (2013-11-25 16:11:52 UTC) #2
floitsch
PTAL. Ivan asked me to remove the getter for the closure and the code now ...
7 years ago (2013-11-29 15:35:57 UTC) #3
vsm
lgtm
7 years ago (2013-12-03 15:14:39 UTC) #4
vsm
7 years ago (2013-12-09 21:14:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r1631 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698