Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 850813002: Upstream Site Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@location_settings_singleton
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/findbugs_filter/findbugs_exclude.xml
diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index 0fff63624333059a8e4a2acbcf777070f4877ba4..b832898412b028eb2f396c48fdb272bb16d0be35 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -113,4 +113,15 @@ In particular, ~ at the start of a string means it's a regex.
<Method name="destroy" />
<Bug code="ST" />
</Match>
+ <!-- Ignore lazy initialization warnings in LocationSettings, which is explicitly
+ single-threaded. -->
+ <Match>
+ <Class name="org.chromium.chrome.browser.preferences.LocationSettings" />
+ <Bug pattern="LI_LAZY_INIT_STATIC" />
+ </Match>
+ <!-- WebsitePreference.compareTo() is indeed consistent with equals(). -->
+ <Match>
+ <Class name="org.chromium.chrome.browser.preferences.website.WebsitePreference" />
+ <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS" />
+ </Match>
</FindBugsFilter>

Powered by Google App Engine
This is Rietveld 408576698