Upstream Site Settings.

Upstream Site Settings.

This adds Site Settings to Chrome Shell, which allows the user to
control website-specific permissions such as Location, JavaScript, and
Pop-ups.

This also upstreams LocationSettings, which is used by Site Settings.

BUG=428869
NOTRY=true

Committed: https://crrev.com/edd5e9f35eb0b2a9f9fbb012a164c0a63ead96e5
Cr-Commit-Position: refs/heads/master@{#311692}

[newt (away), 2015-01-13 21:35:38]

newt@chromium.org changed reviewers:
+ dtrainor@chromium.org

[newt (away), 2015-01-13 21:35:40]

PTAL

Almost everything in this CL is just copy-pasted. Here are the exceptions:
 - ChromiumApplication.java - added createLocationSettings(), which returns a
LocationSettings and can be overridden in subclasses of ChromiumApplication.
 - Preferences.java - added showGoogleTranslateHelp() which can be implemented
in a subclass of Preferences
 - ContentPreferencesTest.java - added three helper methods at the bottom of the
file (runJavaScriptCodeInCurrentTab(), getInfoBars(), and getTabCount()
 - ChromeShellTestBase.java - added loadUrl(), which does what you'd expect
 - chrome_shell_main_preferences.xml - added a preference to show Site Settings
in Chrome Shell
 - geolocation_permission_context_android.cc - stopped using
GoogleLocationSettingsHelper::Create() (as explained in http://crbug.com/448400)

[newt (away), 2015-01-13 21:40:56]

newt@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[newt (away), 2015-01-13 21:40:57]

mvanouwerkerk: Could you take a look at
geolocation_permission_context_android.cc? This change needs to happen as part
of this CL to avoid breaking downstream dependencies.

[newt (away), 2015-01-13 21:42:09]

newt@chromium.org changed reviewers:
+ jbudorick@chromium.org

[newt (away), 2015-01-13 21:42:10]

jbudorick@chromium.org: PTAL findbugs_exclude.xml. The new exclusions have just
been copied from downstream.

[jbudorick, 2015-01-13 21:45:06]

findbugs_exclude.xml lgtm

[Michael van Ouwerkerk, 2015-01-14 10:58:57]

lgtm for geolocation

[David Trainor- moved to gerrit, 2015-01-14 18:32:32]

lgtm

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
(right):

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:35:
* Returns an instance of LocationSettings to be installed as a singleton.
@return?

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java
(right):

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java:363:
return getActivity().getActiveTab().getInfoBarContainer().getInfoBars();
getInfoBarContainer() can return null if the tab doesn't have a ContentViewCore
yet.  But that might not be a case we care about here.

[newt (away), 2015-01-14 18:44:01]

Thanks for the review!

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
(right):

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:35:
* Returns an instance of LocationSettings to be installed as a singleton.
On 2015/01/14 18:32:31, David Trainor wrote:
> @return?

"Returns xyz" is actually preferred by the Google style guide.

https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s7.2-summar...

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java
(right):

https://chromiumcodereview.appspot.com/850813002/diff/20001/chrome/android/ja...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java:363:
return getActivity().getActiveTab().getInfoBarContainer().getInfoBars();
On 2015/01/14 18:32:31, David Trainor wrote:
> getInfoBarContainer() can return null if the tab doesn't have a
ContentViewCore
> yet.  But that might not be a case we care about here.

There is always be a tab loaded when this method is called. If not, the test has
already failed, so it seems fine to throw an NPE.

[newt (away), 2015-01-14 19:04:23]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-14 19:06:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850813002/20001

[commit-bot: I haz the power, 2015-01-14 21:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 21:13:12]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[newt (away), 2015-01-15 05:05:57]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-15 05:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850813002/40001

[commit-bot: I haz the power, 2015-01-15 05:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 05:58:17]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[newt (away), 2015-01-15 18:02:53]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-01-15 18:02:54]

The CQ bit was unchecked by newt@chromium.org

[newt (away), 2015-01-15 18:03:21]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-15 18:04:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850813002/40001

[commit-bot: I haz the power, 2015-01-15 18:07:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-15 18:08:16]

Patchset 3 (id:??) landed as
https://crrev.com/edd5e9f35eb0b2a9f9fbb012a164c0a63ead96e5
Cr-Commit-Position: refs/heads/master@{#311692}