Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: sandbox/linux/services/credentials.h

Issue 849893004: Move a couple of utility functions to a new namespace_utils class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to SupportsUnprivilegedNamespace, which always checks for user namespace support Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/linux/services/credentials.h
diff --git a/sandbox/linux/services/credentials.h b/sandbox/linux/services/credentials.h
index fc65afcd5f6c7e39786f0439a45b0364deaeac78..06ff8fd9a078a225398bd6d54250dcc0e52ab77d 100644
--- a/sandbox/linux/services/credentials.h
+++ b/sandbox/linux/services/credentials.h
@@ -36,13 +36,6 @@ class SANDBOX_EXPORT Credentials {
// debugging and tests.
static scoped_ptr<std::string> GetCurrentCapString();
- // Returns whether the kernel supports CLONE_NEWUSER and whether it would be
- // possible to immediately move to a new user namespace. There is no point
- // in using this method right before calling MoveToNewUserNS(), simply call
- // MoveToNewUserNS() immediately. This method is only useful to test kernel
- // support ahead of time.
- static bool SupportsNewUserNS();
jln (very slow on Chromium) 2015/01/23 02:48:23 I wonder if we should keep this as "CanCreateProce
rickyz (no longer on Chrome) 2015/01/23 23:59:37 Done - at this point, there pretty messy separatio
-
// Move the current process to a new "user namespace" as supported by Linux
// 3.8+ (CLONE_NEWUSER).
// The uid map will be set-up so that the perceived uid and gid will not

Powered by Google App Engine
This is Rietveld 408576698