Upstream DownloadManagerService

Upstream DownloadManagerService

This change upstreams the DownloadManagerService and OMADownloadHandler class, along with java tests.

BUG=15902
R=dtrainor@chromium.org, jbudorick@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/4ea5f83c5ab828afc143bf97f964b208cbbb5cc4

[qinmin, 2015-01-13 01:37:00]

qinmin@chromium.org changed reviewers:
+ dtrainor@chromium.org

[qinmin, 2015-01-13 01:37:01]

PTAL

[David Trainor- moved to gerrit, 2015-01-13 18:36:14]

lgtm

https://chromiumcodereview.appspot.com/848803002/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://chromiumcodereview.appspot.com/848803002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:48:
public static final long UPDATE_DELAY_MILLIS = 1000;
Can this be private?  It seems like it's only used in this class.

[qinmin, 2015-01-13 19:51:46]

https://codereview.chromium.org/848803002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/848803002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:48:
public static final long UPDATE_DELAY_MILLIS = 1000;
On 2015/01/13 18:36:14, David Trainor wrote:
> Can this be private?  It seems like it's only used in this class.

It is also used in downstream test. Anyway, changed this to private and create
another private variable in down stream

[qinmin, 2015-01-13 19:51:50]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-01-13 19:52:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848803002/20001

[commit-bot: I haz the power, 2015-01-13 20:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 20:51:50]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[qinmin, 2015-01-13 23:27:57]

qinmin@chromium.org changed reviewers:
+ jbudorick@chromium.org

[qinmin, 2015-01-13 23:27:58]

+jbudorick for android/build/OWNERs. 

jbudorick@, the singleton can be only retrieved on the UI thread and there is an
assert in that method. So the findbugs warning is pretty much useless.

[jbudorick, 2015-01-13 23:34:08]

build/android/ lgtm

[qinmin, 2015-01-13 23:51:52]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2015-01-13 23:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848803002/40001

[commit-bot: I haz the power, 2015-01-14 00:01:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 00:01:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2015-01-14 00:10:13]

On 2015/01/14 00:01:36, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I've seen this PRESUBMIT failure a couple of times recently. It's a good idea in
theory, but it's particularly problematic with upstreaming. I'll disable that
check and ping this CL once it lands.

[commit-bot: I haz the power, 2015-01-14 01:35:28]

Patchset 3 (id:??) landed as
https://crrev.com/4ea5f83c5ab828afc143bf97f964b208cbbb5cc4
Cr-Commit-Position: refs/heads/master@{#311387}

[qinmin, 2015-01-14 01:35:33]

Committed patchset #3 (id:40001) manually as
4ea5f83c5ab828afc143bf97f964b208cbbb5cc4 (presubmit successful).