content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 84703003: Allow data URL > 2MB for loadDataWithBaseURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 84703003: Allow data URL > 2MB for loadDataWithBaseURL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 1f31e11b3d97aafbaf3eed29add731ce18bcc4c4..5a55358ad690535a879cf606ab0a6bca5a139917 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -478,6 +478,7 @@ void CheckNavigationEntryMatchLoadParams(

EXPECT_EQ(load_params.extra_headers, entry->extra_headers());

EXPECT_EQ(load_params.is_renderer_initiated, entry->is_renderer_initiated());

+ EXPECT_EQ(load_params.data_for_data_url, entry->GetDataForDataURL());

EXPECT_EQ(load_params.base_url_for_data_url, entry->GetBaseURLForDataURL());

if (!load_params.virtual_url_for_data_url.is_empty()) {

EXPECT_EQ(load_params.virtual_url_for_data_url, entry->GetVirtualURL());

@@ -525,6 +526,8 @@ TEST_F(NavigationControllerTest, LoadURLWithExtraParams_Data) {

NavigationController::LoadURLParams load_params(

GURL("data:text/html,dataurl"));

load_params.load_type = NavigationController::LOAD_TYPE_DATA;

+ load_params.data_for_data_url = new base::RefCountedStaticMemory(

+ reinterpret_cast<const uint8*>("<body>Hello world</body>"), 24);

load_params.base_url_for_data_url = GURL("http://foo");

load_params.virtual_url_for_data_url = GURL(kAboutBlankURL);

load_params.override_user_agent = NavigationController::UA_OVERRIDE_FALSE;