Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5789)

Unified Diff: chrome/browser/printing/printer_manager_dialog_linux.cc

Issue 846753002: Update EnsureProcessGetsReaped to receive a pid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/printer_manager_dialog_linux.cc
diff --git a/chrome/browser/printing/printer_manager_dialog_linux.cc b/chrome/browser/printing/printer_manager_dialog_linux.cc
index cc36c3c3a2c6932505d56792bf130130f215b9ae..998ea5a1f2edf1f9eb90b70a9470a8c6630734b3 100644
--- a/chrome/browser/printing/printer_manager_dialog_linux.cc
+++ b/chrome/browser/printing/printer_manager_dialog_linux.cc
@@ -49,12 +49,12 @@ void DetectAndOpenPrinterConfigDialog() {
std::vector<std::string> argv;
argv.push_back(command);
- base::ProcessHandle handle;
- if (!base::LaunchProcess(argv, base::LaunchOptions(), &handle)) {
+ base::Process process = base::LaunchProcess(argv, base::LaunchOptions());
+ if (!process.IsValid()) {
LOG(ERROR) << "Failed to open printer manager dialog ";
return;
}
- base::EnsureProcessGetsReaped(handle);
+ base::EnsureProcessGetsReaped(process.pid());
}
} // anonymous namespace

Powered by Google App Engine
This is Rietveld 408576698