Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/chromeos/system/input_device_settings_impl_x11.cc

Issue 846753002: Update EnsureProcessGetsReaped to receive a pid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system/input_device_settings_impl_x11.cc
diff --git a/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc b/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc
index 0c10157b9c088a4ab674be9ba0d241593bd34076..a4c05e4918d3f11cfbe6595826f7500dfc638fbf 100644
--- a/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc
+++ b/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc
@@ -55,9 +55,10 @@ void ExecuteScriptOnFileThread(const std::vector<std::string>& argv) {
if (!ScriptExists(script))
return;
- base::ProcessHandle handle;
- base::LaunchProcess(base::CommandLine(argv), base::LaunchOptions(), &handle);
- base::EnsureProcessGetsReaped(handle);
+ base::Process process =
+ base::LaunchProcess(base::CommandLine(argv), base::LaunchOptions());
+ if (process.IsValid())
+ base::EnsureProcessGetsReaped(process.pid());
}
void ExecuteScript(const std::vector<std::string>& argv) {

Powered by Google App Engine
This is Rietveld 408576698