Increase nesting in conditional expressions. Fix #122.

Increase nesting in conditional expressions. Fix #122.

BUG=https://github.com/dart-lang/dart_style/issues/122
R=pquitslund@google.com

Committed: 37a6113acbee977d06c005fb5a2f91b925537d8e

[Bob Nystrom, 2015-01-09 18:44:30]

rnystrom@google.com changed reviewers:
+ pquitslund@google.com

[pquitslund, 2015-01-09 18:59:12]

LGTM.

Aside: it's amazing how unreadable expressions like this are *to me*.  That
said, I don't think the formatter can help that much.  (I suspect parens would
help a lot actually.)

https://chromiumcodereview.appspot.com/843653005/diff/1/test/splitting/expres...
File test/splitting/expressions.stmt (right):

https://chromiumcodereview.appspot.com/843653005/diff/1/test/splitting/expres...
test/splitting/expressions.stmt:106: someParticularlyLongOperand;
Please shoot me if you ever see me write code like this.

[Bob Nystrom, 2015-01-09 19:14:54]

On 2015/01/09 18:59:12, pquitslund wrote:
> LGTM.
> 
> Aside: it's amazing how unreadable expressions like this are *to me*.

Definitely don't look at the regression suite, then. :)

People *do* write code like this.

> I don't think the formatter can help that much.  (I suspect parens would
> help a lot actually.)

I actually think the thing that really fixes these is moving conditional
operators to the left. For example:

var xsrfValue = _urlIsSameOrigin(url)
    ? _cookies[xsrfCookieName != null
        ? xsrfCookieName
        : defaults.xsrfCookieName]
    : null;

Still not great, but not much worse than nested if statements to my eye.

>
https://chromiumcodereview.appspot.com/843653005/diff/1/test/splitting/expres...
> test/splitting/expressions.stmt:106: someParticularlyLongOperand;
> Please shoot me if you ever see me write code like this.

Once the robot laser integration is complete, future versions of the formatter
will do this automatically.

- bob

[Bob Nystrom, 2015-01-09 19:15:07]

Committed patchset #1 (id:1) manually as
37a6113acbee977d06c005fb5a2f91b925537d8e (presubmit successful).