[Clank IME] Make keyCode detection sensitive to autocomplete=on|off.

content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.os.Handler;
 import android.os.ResultReceiver;
 import android.os.SystemClock;
 import android.text.Editable;
@@ skipping 401 matching lines @@
         mViewEmbedder.onImeEvent();
 
         String textStr = text.toString();
         int keyCode = shouldSendKeyEventWithKeyCode(textStr);
         long timeStampMs = SystemClock.uptimeMillis();
 
         if (keyCode != COMPOSITION_KEY_CODE) {
             sendKeyEventWithKeyCode(keyCode,
                     KeyEvent.FLAG_SOFT_KEYBOARD | KeyEvent.FLAG_KEEP_TOUCH_MODE);
         } else {
-            KeyEvent keyEvent = getTypedKeyEventGuess(mLastComposeText, textStr);
+            KeyEvent keyEvent = null;
+            // If autocomplete off then use heuristic to compute keyEvent.

[bcwhite, 2015/01/12 20:46:54]

You don't need this change.  Always call Guess so the value is available for the
single-character-commit case at line 436/437.

[huangs, 2015/01/12 20:52:37]

Done.

+            if ((mTextInputFlags & sTextInputFlagAutocompleteOff) != 0) {
+                keyEvent = getTypedKeyEventGuess(mLastComposeText, textStr);
+            }
             int modifiers = 0;
             if (keyEvent != null) {
                 keyCode = keyEvent.getKeyCode();
                 modifiers = getModifiers(keyEvent.getMetaState());
             } else if (!textStr.equals(mLastComposeText)) {
                 keyCode = KeyEvent.KEYCODE_UNKNOWN;
             } else {
                 keyCode = -1;
             }
 
             // If this is a commit with no previous composition, then treat it as a native
             // KeyDown/KeyUp pair with no composition rather than a synthetic pair with
             // composition below.
             if (keyCode > 0 && isCommit && mLastComposeText == null) {
                 mLastSyntheticKeyCode = keyCode;
                 return translateAndSendNativeEvents(keyEvent, 0)
                         && translateAndSendNativeEvents(
                                 KeyEvent.changeAction(keyEvent, KeyEvent.ACTION_UP), 0);
             }
 
+            if ((mTextInputFlags & sTextInputFlagAutocompleteOff) == 0) {

[bcwhite, 2015/01/12 20:46:54]

Comment above stating why with reference to the issue.

[huangs, 2015/01/12 20:52:37]

Done.

+                keyCode = COMPOSITION_KEY_CODE;
+                modifiers = 0;
+            }
+
             // When typing, there is no issue sending KeyDown and KeyUp events around the
             // composition event because those key events do nothing (other than call JS
             // handlers).  Typing does not cause changes outside of a KeyPress event which
             // we don't call here.  However, if the key-code is a control key such as
             // KEYCODE_DEL then there never is an associated KeyPress event and the KeyDown
             // event itself causes the action.  The net result below is that the Renderer calls
             // cancelComposition() and then Android starts anew with setComposingRegion().
             // This stopping and restarting of composition could be a source of problems
             // with 3rd party keyboards.
             //
@@ skipping 257 matching lines @@
     private native void nativeDeleteSurroundingText(long nativeImeAdapterAndroid,
             int before, int after);
 
     private native void nativeUnselect(long nativeImeAdapterAndroid);
     private native void nativeSelectAll(long nativeImeAdapterAndroid);
     private native void nativeCut(long nativeImeAdapterAndroid);
     private native void nativeCopy(long nativeImeAdapterAndroid);
     private native void nativePaste(long nativeImeAdapterAndroid);
     private native void nativeResetImeAdapter(long nativeImeAdapterAndroid);
 }