Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 841993003: dart2js: Only emit constructors of the native class interceptors that are used. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
index 6a8381564379138dd1b8e1aed7cc4575122b3c6f..014ee3880087c214f72c03ba156cfb3b4b2f3577 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
@@ -63,6 +63,9 @@ class ClassEmitter extends CodeEmitterHelper {
className, classElement, builder, properties);
}
+ /**
+ * [emitClassConstructor] affects the generation of constructors in CSP mode.
+ */
void emitClassConstructor(ClassElement classElement,
ClassBuilder builder,
{bool onlyForRti: false}) {
@@ -218,6 +221,11 @@ class ClassEmitter extends CodeEmitterHelper {
return fieldsAdded;
}
+ /**
+ * [emitClassGettersSetters] does not affect whether or not a class is needed
floitsch 2015/01/15 15:14:40 That comment is out of context. It should say som
zarah 2015/01/16 08:48:50 You are right. Comment updated.
+ * If getters/setters are emitted, the class has fields and is therefore
+ * non-trivial.
+ */
void emitClassGettersSetters(ClassElement classElement,
ClassBuilder builder,
{bool onlyForRti: false}) {

Powered by Google App Engine
This is Rietveld 408576698