Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 83943002: Adding UMA metric to record the type of suggestion displayed on the NTP's Most Visited section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Answered Mathieu's comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
index dc1df81ea28f2dd45a4f3b6f26d4e018fce78f3e..4e1171ed7a4a75acc56f7d6bd4bfbe1bf9066851 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
@@ -29,6 +29,10 @@ class NTPUserDataLogger
// session to UMA histogram. Called when the user navigates to a URL.
void EmitThumbnailErrorRate();
+ // Logs the type of the suggestions that were shown on this NTP. Called when
+ // the user navigates to a URL.
+ void EmitSuggestionsType();
+
// Logs total number of mouseovers per NTP session to UMA histogram. Called
// when an NTP tab is about to be deactivated (be it by switching tabs, losing
// focus or closing the tab/shutting down Chrome), or when the user navigates
@@ -72,6 +76,10 @@ class NTPUserDataLogger
// thumbnail image and that caused a fallback to the secondary thumbnail.
size_t number_of_fallback_thumbnails_used_;
+ // True if at least one iframe came from a server-side suggestion. In
+ // practice, either all the iframes are server-side suggestions or none are.
+ bool server_side_suggestions_;
+
// The URL of this New Tab Page - varies based on NTP version.
GURL ntp_url_;
« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_util.js ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698