Adding UMA metric to record the type of suggestion displayed on the NTP's Most Visited section.

chrome/browser/resources/local_ntp/most_visited_util.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview Utilities for rendering most visited thumbnails and titles.
  */
 
 <include src="instant_iframe_validation.js">
@@ skipping 11 matching lines @@
   // The page attempted to load a thumbnail image.
   NTP_THUMBNAIL_ATTEMPT: 1,
   // There was an error in loading both the thumbnail image and the fallback
   // (if it was provided), resulting in a grey tile.
   NTP_THUMBNAIL_ERROR: 2,
   // The page attempted to load a thumbnail URL while a fallback thumbnail was
   // provided.
   NTP_FALLBACK_THUMBNAIL_REQUESTED: 3,
   // The primary thumbnail image failed to load and caused us to use the
   // secondary thumbnail as a fallback.
-  NTP_FALLBACK_THUMBNAIL_USED: 4
+  NTP_FALLBACK_THUMBNAIL_USED: 4,
+  // We got a suggestion coming from the server.

[Mathieu, 2013/11/22 19:58:19]

nit: Remove reference to "We" here and below

[beaudoin, 2013/11/22 20:09:35]

Done.

+  NTP_SERVER_SIDE_SUGGESTION: 5
 };
 
 
 /**
  * Parses query parameters from Location.
  * @param {string} location The URL to generate the CSS url for.
  * @return {Object} Dictionary containing name value pairs for URL.
  */
 function parseQueryParams(location) {
   var params = Object.create(null);
@@ skipping 113 matching lines @@
   var data = {};
   if (params.url) {
     // Means that we get suggestion data from the server. Create data object.
     data.url = params.url;
     data.thumbnailUrl = params.tu || '';
     data.thumbnailUrl2 = params.tu2 || '';
     data.title = params.ti || '';
     data.direction = params.di || '';
     data.domain = params.dom || '';
     data.ping = params.ping || '';
+    // Log the fact that we got a server suggestion
+    var ntpApiHandle = chrome.embeddedSearch.newTabPage;
+    ntpApiHandle.logEvent(NTP_LOGGING_EVENT_TYPE.NTP_SERVER_SIDE_SUGGESTION);
   } else {
     var apiHandle = chrome.embeddedSearch.searchBox;
     data = apiHandle.getMostVisitedItemData(params.rid);
     if (!data)
       return;
     delete data.ping;
   }
   if (/^javascript:/i.test(data.url) ||
       /^javascript:/i.test(data.thumbnailUrl) ||
       /^javascript:/i.test(data.thumbnailUrl2))
     return;
   if (data.direction)
     document.body.dir = data.direction;
   fill(params, data);
 }