Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 83843002: Move ManifestHandlers to extensions/ (Closed)

Created:
7 years ago by Devlin
Modified:
7 years ago
Reviewers:
Finnur, Yoyo Zhou, DaveMoore
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move ManifestHandlers to extensions/ Move ManifestHandlers for: - CSP - Kiosk Mode - Offline Enabled - Requirements - Sandboxed Page to top-level extensions/common/manifest_handlers. Rename all handlers to be foo_info.h/cc, if necessary. TBR=davemoore@chromium.org (c/b/chromeos/app_mode/startup_app_launcher.cc) TBR=finnur@chromium.org (c/b/ui/webui/extensions/extension_basic_info.cc) BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237426

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/handler/info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1306 lines) Patch
M apps/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M apps/launcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/requirements_checker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_basic_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/common/extensions/csp_handler.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/common/extensions/csp_handler.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/common/extensions/csp_validator.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/common/extensions/csp_validator.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/common/extensions/csp_validator_unittest.cc View 1 chunk +0 lines, -180 lines 0 comments Download
M chrome/common/extensions/extension_set.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/manifest_handlers/kiosk_mode_info.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/kiosk_mode_info.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/offline_enabled_info.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/offline_enabled_info.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/requirements_handler.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/requirements_handler.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/sandboxed_page_info.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/sandboxed_page_info.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 2 chunks +1 line, -1 line 0 comments Download
A + extensions/common/csp_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/csp_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/csp_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/csp_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/csp_info.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/kiosk_mode_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/kiosk_mode_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/offline_enabled_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/offline_enabled_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/requirements_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/requirements_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/sandboxed_page_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/sandboxed_page_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
While I'm here, should we reconcile the naming scheme for handlers (handler vs. info)?
7 years ago (2013-11-22 20:52:49 UTC) #1
Yoyo Zhou
LGTM for these, but update the CL description to say which ones. How are you ...
7 years ago (2013-11-22 23:15:18 UTC) #2
Devlin
In general, I'm only moving the ones that don't reference Chrome-specific logic or ideas (though ...
7 years ago (2013-11-26 19:09:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/83843002/120001
7 years ago (2013-11-26 19:11:42 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-26 22:59:31 UTC) #5
Message was sent while issue was closed.
Change committed as 237426

Powered by Google App Engine
This is Rietveld 408576698