content/common/gpu/media/tegra_v4l2_video_device.h - Issue 833063003: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/tegra_v4l2_video_device.h

Issue 833063003: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/media/h264_dpb.cc ('K') | « content/common/gpu/media/h264_dpb.cc ('k') | content/common/gpu/media/v4l2_image_processor.h » ('j') | content/common/gpu/media/v4l2_image_processor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/tegra_v4l2_video_device.h

diff --git a/content/common/gpu/media/tegra_v4l2_video_device.h b/content/common/gpu/media/tegra_v4l2_video_device.h

index e9516faaf6c18784f6ffd15a824356de22bbe81c..e97c45616e9035804f1dfcfe2d1b6c041fe6c468 100644

--- a/content/common/gpu/media/tegra_v4l2_video_device.h

+++ b/content/common/gpu/media/tegra_v4l2_video_device.h

@@ -19,7 +19,6 @@ namespace content {

class TegraV4L2Device : public V4L2Device {

public:

explicit TegraV4L2Device(Type type);

- virtual ~TegraV4L2Device();

int Ioctl(int flags, void* arg) override;

bool Poll(bool poll_device, bool* event_pending) override;

@@ -46,6 +45,8 @@ class TegraV4L2Device : public V4L2Device {

uint32 PreferredInputFormat() override;

private:

+ virtual ~TegraV4L2Device();

scherkus (not reviewing) 2015/01/13 01:24:59 override

Pawel Osciak 2015/01/13 11:33:34 Done.

const Type type_;

// The actual device fd.