content/common/gpu/media/generic_v4l2_video_device.h - Issue 833063003: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/generic_v4l2_video_device.h

Issue 833063003: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/accelerated_video_decoder.h ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | content/common/gpu/media/h264_decoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/generic_v4l2_video_device.h

diff --git a/content/common/gpu/media/generic_v4l2_video_device.h b/content/common/gpu/media/generic_v4l2_video_device.h

index 39d6df6d77e1d35fc81aae676d5c25a96e13ce8c..0e3c89de26ae418a72e645c7e9b6b1cd08869c57 100644

--- a/content/common/gpu/media/generic_v4l2_video_device.h

+++ b/content/common/gpu/media/generic_v4l2_video_device.h

@@ -15,7 +15,6 @@ namespace content {

class GenericV4L2Device : public V4L2Device {

public:

explicit GenericV4L2Device(Type type);

- virtual ~GenericV4L2Device();

// V4L2Device implementation.

int Ioctl(int request, void* arg) override;

@@ -43,6 +42,8 @@ class GenericV4L2Device : public V4L2Device {

uint32 PreferredInputFormat() override;

private:

+ virtual ~GenericV4L2Device();

scherkus (not reviewing) 2015/01/13 01:24:59 override

Pawel Osciak 2015/01/13 11:33:34 Done.

const Type type_;

// The actual device fd.