chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

diff --git a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

index 0ad440eb47492d1bfc8fd0fa16c4bffa503f1b2c..2f9000979a0f3cf0a4b5d6a35be16aaf72b26772 100644

--- a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

+++ b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

@@ -84,10 +84,11 @@ int TabModelJniBridge::GetActiveIndex() const {

void TabModelJniBridge::CreateTab(WebContents* web_contents,

int parent_tab_id) {

JNIEnv* env = AttachCurrentThread();

- Java_TabModelJniBridge_createTabWithNativeContents(

+ Java_TabModelJniBridge_createTabWithWebContents(

env, java_object_.get(env).obj(),

web_contents->GetBrowserContext()->IsOffTheRecord(),

- reinterpret_cast<intptr_t>(web_contents), parent_tab_id);

+ web_contents->GetJavaWebContents().obj(),

+ parent_tab_id);

}

WebContents* TabModelJniBridge::GetWebContentsAt(int index) const {