chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ContentViewUtil.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

index 6e19d5f4f9d23a8a98a16cfe61c7749e6f06f424..fb402a0ef26889b24385e7f51d7c3c5219a6064c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

@@ -6,6 +6,8 @@ package org.chromium.chrome.browser;

import android.view.ContextMenu;

+import org.chromium.content_public.browser.WebContents;

/**

* An implementation of the {@link TabObserver} which has empty implementations of all methods.

@@ -110,6 +112,6 @@ public class EmptyTabObserver implements TabObserver {

public void onBackgroundColorChanged(Tab tab, int color) { }

@Override

- public void webContentsCreated(Tab tab, long sourceWebContents, long openerRenderFrameId,

- String frameName, String targetUrl, long newWebContents) { }

+ public void webContentsCreated(Tab tab, WebContents sourceWebContents, long openerRenderFrameId,

+ String frameName, String targetUrl, WebContents newWebContents) { }

}