chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_settings.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/ContentViewUtil.java » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

index c2de4a223f215095799dc9e898439b008e660c88..cd157ebf4cfbaf7fc5fc0dfbaed50ccff6c66ddf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

@@ -9,6 +9,7 @@ import android.graphics.RectF;

import org.chromium.base.CalledByNative;

import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid;

+import org.chromium.content_public.browser.WebContents;

/**

* Chromium Android specific WebContentsDelegate.

@@ -27,14 +28,14 @@ public class ChromeWebContentsDelegateAndroid extends WebContentsDelegateAndroid

}

@CalledByNative

- public boolean addNewContents(long nativeSourceWebContents, long nativeWebContents,

+ public boolean addNewContents(WebContents sourceWebContents, WebContents webContents,

int disposition, Rect initialPosition, boolean userGesture) {

return false;

}

@Override

- public void webContentsCreated(long sourceWebContents, long openerRenderFrameId,

- String frameName, String targetUrl, long newWebContents) {

+ public void webContentsCreated(WebContents sourceWebContents, long openerRenderFrameId,

+ String frameName, String targetUrl, WebContents newWebContents) {

}

// Helper functions used to create types that are part of the public interface