android_webview/native/aw_contents.h - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.h

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_contents.h

diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h

index 4a4afbbe981f25b935f9bc46690c6ee6b8fa4a4e..d91a15090c7f03ef093eb02271e1b5ee971f9722 100644

--- a/android_webview/native/aw_contents.h

+++ b/android_webview/native/aw_contents.h

@@ -88,7 +88,8 @@ class AwContents : public FindHelper::Listener,

jobject contents_client_bridge,

jobject io_thread_client,

jobject intercept_navigation_delegate);

- jlong GetWebContents(JNIEnv* env, jobject obj);

+ base::android::ScopedJavaLocalRef<jobject> GetWebContents(JNIEnv* env,

+ jobject obj);

void Destroy(JNIEnv* env, jobject obj);

void DocumentHasImages(JNIEnv* env, jobject obj, jobject message);