base/process/process_util_unittest.cc - Issue 831373002: Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_util_unittest.cc

Issue 831373002: Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/process_util_unittest.cc

diff --git a/base/process/process_util_unittest.cc b/base/process/process_util_unittest.cc

index af88fe1fd3a01f2ce3c10427e77b26645ba6eda8..0f6b75dddb437fe866fe90baab033bdfdb9a48f6 100644

--- a/base/process/process_util_unittest.cc

+++ b/base/process/process_util_unittest.cc

@@ -684,10 +684,8 @@ TEST_F(ProcessUtilTest, LaunchProcess) {

// Test a non-trival value for clone_flags.

// Don't test on Valgrind as it has limited support for clone().

if (!RunningOnValgrind()) {

- EXPECT_EQ(

- "wibble\n",

- TestLaunchProcess(

- echo_base_test, env_changes, no_clear_environ, CLONE_FS | SIGCHLD));

+ EXPECT_EQ("wibble\n", TestLaunchProcess(echo_base_test, env_changes,

+ no_clear_environ, CLONE_FS));

}

EXPECT_EQ(

« no previous file with comments | « base/process/process_unittest.cc ('k') | content/zygote/zygote_linux.cc » ('j') | no next file with comments »