base/process/launch.h - Issue 831373002: Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/launch.h

Issue 831373002: Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/launch.h

diff --git a/base/process/launch.h b/base/process/launch.h

index 0450ddf021e0faa7936bf7118951d050e185251b..8a63b8493b72dcdbc8b1fb61812cbf0eec2dbc23 100644

--- a/base/process/launch.h

+++ b/base/process/launch.h

@@ -115,6 +115,9 @@ struct BASE_EXPORT LaunchOptions {

#if defined(OS_LINUX)

// If non-zero, start the process using clone(), using flags as provided.

+ // Unlike in clone, clone_flags may not contain a custom termination signal

+ // that is sent to the parent when the child dies. The termination signal will

+ // always be set to SIGCHLD.

int clone_flags;

// By default, child processes will have the PR_SET_NO_NEW_PRIVS bit set. If

« no previous file with comments | « no previous file | base/process/launch_posix.cc » ('j') | no next file with comments »