Add the ability to run a callback between fork and exec.

base/process/process_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/process.h"
 
+#include "base/posix/eintr_wrapper.h"
 #include "base/process/kill.h"
 #include "base/test/multiprocess_test.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/platform_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/multiprocess_func_list.h"
 
 
 namespace {
 
@@ skipping 177 matching lines @@
   EXPECT_TRUE(process.SetProcessBackgrounded(false));
   EXPECT_FALSE(process.IsProcessBackgrounded());
 #else
   process.SetProcessBackgrounded(true);
   process.SetProcessBackgrounded(false);
 #endif
   int new_priority = process.GetPriority();
   EXPECT_EQ(old_priority, new_priority);
 }
 
+#if defined(OS_POSIX)
+const char kPipeValue = '\xcc';
+
+class ReadFromPipeDelegate : public LaunchOptions::PreExecDelegate {
+ public:
+  explicit ReadFromPipeDelegate(int fd) : fd_(fd) {}
+  ~ReadFromPipeDelegate() override {}
+  void RunAsyncSafe() override {
+    char c;
+    RAW_CHECK(HANDLE_EINTR(read(fd_, &c, 1)) == 1);
+    RAW_CHECK(IGNORE_EINTR(close(fd_)) == 0);
+    RAW_CHECK(c == kPipeValue);
+  }
+
+ private:
+  int fd_;
+};

[jln (very slow on Chromium), 2015/01/07 00:40:37]

Style: DISALLOW_COPY_AND_ASSIGN

[rickyz (no longer on Chrome), 2015/01/07 01:39:07]

Done.

+
+TEST_F(ProcessTest, PreExecHook) {
+  int pipe_fds[2];
+  ASSERT_EQ(0, pipe(pipe_fds));
+
+  const int read_fd = pipe_fds[0];

[jln (very slow on Chromium), 2015/01/07 00:40:38]

How about making these ScopedFDs instead? That way we don't leak if an assert
fails.

[rickyz (no longer on Chrome), 2015/01/07 01:39:07]

Sure - I kept the raw fd in the delegate because ScopedFD uses PCHECK.

+  const int write_fd = pipe_fds[1];
+  base::FileHandleMappingVector fds_to_remap;
+  fds_to_remap.push_back(std::make_pair(read_fd, read_fd));
+
+  ReadFromPipeDelegate read_from_pipe_delegate(read_fd);
+  LaunchOptions options;
+  options.fds_to_remap = &fds_to_remap;
+  options.pre_exec_delegate = &read_from_pipe_delegate;
+  Process process(SpawnChildWithOptions("SimpleChildProcess", options));
+  ASSERT_TRUE(process.IsValid());
+
+  ASSERT_EQ(0, IGNORE_EINTR(close(read_fd)));
+  ASSERT_EQ(1, HANDLE_EINTR(write(write_fd, &kPipeValue, 1)));
+  ASSERT_EQ(0, IGNORE_EINTR(close(write_fd)));
+
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExit(&exit_code));
+  EXPECT_EQ(0, exit_code);
+}
+#endif

[jln (very slow on Chromium), 2015/01/07 00:40:38]

Style: // defined(OS_POSIX)

[rickyz (no longer on Chrome), 2015/01/07 01:39:07]

Done.

+
 }  // namespace base