Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.h

Issue 826663002: Support multiple video decoders and encoders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address patch set 4 review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/gpu_video_decode_accelerator.h
diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.h b/content/common/gpu/media/gpu_video_decode_accelerator.h
index e59a76fb5c35169dd4b0fab8cb448e9bc02a46b3..c6245a3ae017779b755ed3ff629fefc5ec1ba755 100644
--- a/content/common/gpu/media/gpu_video_decode_accelerator.h
+++ b/content/common/gpu/media/gpu_video_decode_accelerator.h
@@ -59,8 +59,9 @@ class GpuVideoDecodeAccelerator
// Function to delegate sending to actual sender.
bool Send(IPC::Message* message) override;
- // Initialize the accelerator with the given profile and send the
- // |init_done_msg| when done.
+ // Prepare all appropriate platform-specific VDAs and send the
+ // |init_done_msg| when initialize one of accelerators with |profile|
Pawel Osciak 2014/12/30 06:14:38 We send the message always, just with a different
henryhsu 2014/12/30 14:40:51 Done.
+ // successfully.
void Initialize(const media::VideoCodecProfile profile,
IPC::Message* init_done_msg);
@@ -70,6 +71,11 @@ class GpuVideoDecodeAccelerator
// We only allow self-delete, from OnWillDestroyStub(), after cleanup there.
~GpuVideoDecodeAccelerator() override;
+ // Initialize VDA for |profile|. Return true when initialization succeeded
+ // and filter_ is passed to GpuCommandBufferStube channel only if we can
+ // decode on IO thread.
+ bool InitializeDecoder(media::VideoCodecProfile profile);
+
// Handlers for IPC messages.
void OnDecode(base::SharedMemoryHandle handle, int32 id, uint32 size);
void OnAssignPictureBuffers(const std::vector<int32>& buffer_ids,

Powered by Google App Engine
This is Rietveld 408576698