media/video/video_encode_accelerator.h - Issue 826663002: Support multiple video decoders and encoders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/video_encode_accelerator.h

Issue 826663002: Support multiple video decoders and encoders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nits Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/video_encode_accelerator.h

diff --git a/media/video/video_encode_accelerator.h b/media/video/video_encode_accelerator.h

index 9551c22a769d58473bfbfa66bfc92d712a3d164b..9bae67751bf44d68d0b917179d9cd4eeb047433b 100644

--- a/media/video/video_encode_accelerator.h

+++ b/media/video/video_encode_accelerator.h

@@ -144,7 +144,6 @@ class MEDIA_EXPORT VideoEncodeAccelerator {

// |this| unconditionally, so make sure to drop all pointers to it!

virtual void Destroy() = 0;

- protected:

// Do not delete directly; use Destroy() or own it with a scoped_ptr, which

Pawel Osciak 2014/12/26 01:11:36 Please don't remove protected.

henryhsu 2014/12/26 08:40:41 oh ok. I removed this is due to ScopedVector. Now

// will Destroy() it properly by default.

virtual ~VideoEncodeAccelerator();