Adds support for media permission request handling on <appview> tag.

Adds support for media permission request handling on <appview> tag.

BUG=443377
Committed: https://crrev.com/94df224252d8304792b53bbefe8c97b761710315
Cr-Commit-Position: refs/heads/master@{#309444}

[lfg, 2014-12-19 00:41:56]

Media on <appview>, PTAL.

[lfg, 2014-12-19 00:42:34]

lfg@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-12-19 11:21:51]

lgtm + nits

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/app_view/app_view_guest.cc (right):

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/app_view/app_view_guest.cc:145: callback);
early exit after so you don't need else. Slight improvement to readability.

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/app_view/app_view_guest.cc:163: web_contents,
security_origin, type);
early exit then remove else.

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/app_view/app_view_guest_delegate.h (right):

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/app_view/app_view_guest_delegate.h:27: // Returns
an AppDelegate to be used by the AppViewGuest
Period at the end. Also might be useful to explain what an AppDelegate does.

[lfg, 2014-12-19 16:29:08]

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/app_view/app_view_guest.cc (right):

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/app_view/app_view_guest.cc:145: callback);
On 2014/12/19 11:21:51, Fady Samuel wrote:
> early exit after so you don't need else. Slight improvement to readability.

Done.

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/app_view/app_view_guest.cc:163: web_contents,
security_origin, type);
On 2014/12/19 11:21:51, Fady Samuel wrote:
> early exit then remove else.

Done.

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/app_view/app_view_guest_delegate.h (right):

https://codereview.chromium.org/820583002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/app_view/app_view_guest_delegate.h:27: // Returns
an AppDelegate to be used by the AppViewGuest
On 2014/12/19 11:21:51, Fady Samuel wrote:
> Period at the end. Also might be useful to explain what an AppDelegate does.

Done.

[lfg, 2014-12-19 16:34:39]

lfg@chromium.org changed reviewers:
+ yoz@chromium.org

[lfg, 2014-12-19 16:34:39]

Hi Yoyo, please take a look.

[Yoyo Zhou, 2014-12-19 23:47:27]

LGTM

https://chromiumcodereview.appspot.com/820583002/diff/20001/chrome/browser/gu...
File chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h
(right):

https://chromiumcodereview.appspot.com/820583002/diff/20001/chrome/browser/gu...
chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h:18: //
AppViewGuestDelegate interface
nit: I think a common style for this is just
// AppViewGuestDelegate:

https://chromiumcodereview.appspot.com/820583002/diff/20001/extensions/browse...
File extensions/browser/guest_view/app_view/app_view_guest_delegate.h (right):

https://chromiumcodereview.appspot.com/820583002/diff/20001/extensions/browse...
extensions/browser/guest_view/app_view/app_view_guest_delegate.h:28: // used by
AppView as an interface so that apps can use services in the
nit: I don't know what "as an interface" is supposed to mean here. You could
just not say that.

https://chromiumcodereview.appspot.com/820583002/diff/20001/extensions/shell/...
File extensions/shell/browser/shell_app_view_guest_delegate.h (right):

https://chromiumcodereview.appspot.com/820583002/diff/20001/extensions/shell/...
extensions/shell/browser/shell_app_view_guest_delegate.h:18: //
AppViewGuestDelegate interface
same here

[lfg, 2014-12-22 16:34:58]

https://codereview.chromium.org/820583002/diff/20001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h
(right):

https://codereview.chromium.org/820583002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h:18: //
AppViewGuestDelegate interface
On 2014/12/19 23:47:26, Yoyo Zhou wrote:
> nit: I think a common style for this is just
> // AppViewGuestDelegate:

Done.

https://codereview.chromium.org/820583002/diff/20001/extensions/browser/guest...
File extensions/browser/guest_view/app_view/app_view_guest_delegate.h (right):

https://codereview.chromium.org/820583002/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/app_view/app_view_guest_delegate.h:28: // used by
AppView as an interface so that apps can use services in the
On 2014/12/19 23:47:26, Yoyo Zhou wrote:
> nit: I don't know what "as an interface" is supposed to mean here. You could
> just not say that.

Done.

https://codereview.chromium.org/820583002/diff/20001/extensions/shell/browser...
File extensions/shell/browser/shell_app_view_guest_delegate.h (right):

https://codereview.chromium.org/820583002/diff/20001/extensions/shell/browser...
extensions/shell/browser/shell_app_view_guest_delegate.h:18: //
AppViewGuestDelegate interface
On 2014/12/19 23:47:26, Yoyo Zhou wrote:
> same here

Done.

[lfg, 2014-12-22 18:08:12]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-12-22 18:09:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/820583002/60001

[commit-bot: I haz the power, 2014-12-22 18:53:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-22 18:54:03]

Patchset 4 (id:??) landed as
https://crrev.com/94df224252d8304792b53bbefe8c97b761710315
Cr-Commit-Position: refs/heads/master@{#309444}