app/handlers/package_versions.py - Issue 816693002: Add string versions of User/Pickled objects to datastore models

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/handlers/package_versions.py

Issue 816693002: Add string versions of User/Pickled objects to datastore models (Closed) Base URL: https://github.com/dart-lang/pub-dartlang.git@master

Patch Set: Use db.Text(encoding="utf-8") Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: app/handlers/package_versions.py

diff --git a/app/handlers/package_versions.py b/app/handlers/package_versions.py

index c4628b6e08804aac587a38219b7fe66e62f59bb9..7e862c93700da0a1c2b3c5c049e728fe3230ab47 100644

--- a/app/handlers/package_versions.py

+++ b/app/handlers/package_versions.py

@@ -114,12 +114,14 @@ class PackageVersions(object):

new_version.downloads = version.downloads

new_version.sort_order = version.sort_order

version.delete()

+ new_version.temp_synchronize_uploader_to_uploaderemail_and_pickles()

new_version.put()

# Only save the package if its latest version has been updated.

# Otherwise, its latest version may be being updated in parallel,

# causing icky bugs.

if latest_version_key == key:

+ package.temp_synchronize_uploader_to_uploaderemail()

package.put()

package.invalidate_cache()

« no previous file with comments | « app/handlers/package_uploaders.py ('k') | app/models/package.py » ('j') | no next file with comments »