Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: app/handlers/package_versions.py

Issue 815973002: Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties (Closed) Base URL: https://github.com/dart-lang/pub-dartlang.git@master
Patch Set: Small fix in changelog/readme handling for new uploads Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/handlers/package_uploaders.py ('k') | app/models/package.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/handlers/package_versions.py
diff --git a/app/handlers/package_versions.py b/app/handlers/package_versions.py
index 7e862c93700da0a1c2b3c5c049e728fe3230ab47..e18070c6ae28becd30f5632d2e513592c2116d3a 100644
--- a/app/handlers/package_versions.py
+++ b/app/handlers/package_versions.py
@@ -94,7 +94,7 @@ class PackageVersions(object):
with closing(cloud_storage.read(version.storage_path)) as f:
new_version = PackageVersion.from_archive(
- f, uploader=version.uploader)
+ f, uploaderEmail=version.uploaderEmail)
with models.transaction():
# Reload the old version in case anything (e.g. sort order) changed.
@@ -114,14 +114,12 @@ class PackageVersions(object):
new_version.downloads = version.downloads
new_version.sort_order = version.sort_order
version.delete()
- new_version.temp_synchronize_uploader_to_uploaderemail_and_pickles()
new_version.put()
# Only save the package if its latest version has been updated.
# Otherwise, its latest version may be being updated in parallel,
# causing icky bugs.
if latest_version_key == key:
- package.temp_synchronize_uploader_to_uploaderemail()
package.put()
package.invalidate_cache()
« no previous file with comments | « app/handlers/package_uploaders.py ('k') | app/models/package.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698