Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties

app/models/package.py

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import cgi
 import json
 import logging
 
 from google.appengine.api import memcache
 from google.appengine.api import users
@@ skipping 10 matching lines @@
     package is represented by a PackageVersion model.
 
     Whenever a new PackageVersion for a Package is added or modified, you must
     call invalidate_cache() to ensure any stale cached description of the
     package is discarded.
     """
 
     MAX_SIZE = 10 * 2**20 # 10MB
     """The maximum package size, in bytes."""
 
-    uploaders = db.ListProperty(users.User, validator=models.validate_not_empty)
-    """The users who are allowed to upload new versions of the package.
-
-    When this is set, invalidate_cache() must be called."""
-
-    uploaderEmails = db.StringListProperty()
+    uploaderEmails = db.StringListProperty(validator=models.validate_not_empty)
     """The user emails who are allowed to upload new versions of the package.
 
     When this is set, invalidate_cache() must be called."""
 
     name = db.StringProperty(required=True)
     """The name of the package."""
 
     created = db.DateTimeProperty(auto_now_add=True)
     """When the package was created."""
 
     downloads = db.IntegerProperty(required=True, default=0)
     """The number of times any version of this package has been downloaded."""
 
     # This should only reference a PackageVersion, but cyclic imports aren't
     # allowed so we can't import PackageVersion here.
     latest_version = db.ReferenceProperty()
     """The most recent non-prerelease version of this package.
 
     When this is set, invalidate_cache() must be called."""
 
-    def temp_synchronize_uploaders_to_uploaderemails(self):
-      """ Will synchronize self.uploaders -> self.uploaderEmails. """
-      if self.uploaders is None:
-        self.uploaderEmails = None
-      elif len(self.uploaders) == 0:
-        self.uploaderEmails = self.uploaders
-      else:
-        self.uploaderEmails = [uploader.email() for uploader in self.uploaders]
-
     @property
     def description(self):
         """The short description of the package."""
         if self.latest_version is None: return None
         return self.latest_version.pubspec.get('description')
 
     _MAX_DESCRIPTION_CHARS = 200
 
     @property
     def ellipsized_description(self):
@@ skipping 90 matching lines @@
         """Determine whether a package with the given name exists."""
         return cls.get_by_key_name(name) is not None
 
     def has_version(self, version):
         """Determine whether this package has a given version uploaded."""
         from package_version import PackageVersion
         version = PackageVersion.get_by_name_and_version(
             self.name, str(version))
         return version is not None
 
-    def has_uploader(self, uploader):
+    def has_uploader_email(self, uploaderEmail):
         """Determine whether the given user is an uploader for this package.
 
         This compares users via case-insensitive email comparison.
 
         Although admins have uploader privileges for all packages, this will not
         return True for admins.
         """
-        return uploader.email().lower() in \
+        return uploaderEmail.lower() in \
             [email.lower() for email in self.uploaderEmails]
 
     @property
     def url(self):
         """The API URL for this package."""
         return models.url(
             controller='api.packages', action='show', id=self.name)
 
     def as_dict(self, full=False):
         """Returns the dictionary representation of this package.
@@ skipping 43 matching lines @@
         description of the package changes. This isn't often since most package
         data is immutable, but when the uploader list changes or new versions
         of the package are uploaded, the data will change.
         """
         memcache.delete(self._package_json_cache_key)
 
     @property
     def _package_json_cache_key(self):
         """The memcache key for the cached JSON for this package."""
         return 'package_json_' + self.name