Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties

app/handlers/api/package_uploaders.py

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 from google.appengine.api import oauth
 from google.appengine.api import users
 
 import handlers
 import models
 
 class PackageUploaders(object):
     """The handler for /api/packages/*/uploaders/*."""
 
     @handlers.api(1)
     @handlers.requires_uploader
     @models.transactional
     def create(self, package_id, email):
         """Add a new uploader for this package.
 
         Only other uploaders may add new uploaders."""
 
         package = handlers.request().package
-        user_to_add = users.User(email)
-        if package.has_uploader(user_to_add):
+        if package.has_uploader_email(email):
             handlers.http_error(
                 400, "User '%s' is already an uploader for package '%s'." %
                          (email, package.name))
 
-        package.uploaders.append(user_to_add)
-        package.temp_synchronize_uploaders_to_uploaderemails()
+        package.uploaderEmails.append(email)
         package.put()
         package.invalidate_cache()
         return handlers.json_success(
             "'%s' added as an uploader for package '%s'." %
                 (email, package.name))
 
     @handlers.api(1)
     @handlers.requires_uploader
     @models.transactional
     def delete(self, package_id, id, format=None):
         """Delete one of this package's uploaders.
 
         Only uploaders may delete uploaders. If only one uploader remains, that
         uploader may not be deleted until a new one is added.
         """
 
+        # TODO: WHAT IS THIS `format` THING ?
         if format: id = id + '.' + format
 
         package = handlers.request().package
-        user_to_delete = users.User(id)
-        if not package.has_uploader(user_to_delete):
+        email = id
+        if not package.has_uploader_email(email):
             handlers.http_error(
                 400, "'%s' isn't an uploader for package '%s'." %
-                         (user_to_delete.nickname(), package.name))
+                         (email, package.name))
 
-        if len(package.uploaders) == 1:
+        if len(package.uploaderEmails) == 1:
             handlers.http_error(
                 400, ("Package '%s' only has one uploader, so that uploader " +
-                          "can't be removed.") % package.name)
+                      "can't be removed.") % package.name)
 
-        email_to_delete = user_to_delete.email().lower()
-        package.uploaders = [uploader for uploader in package.uploaders
-                             if uploader.email().lower() != email_to_delete]
-        package.temp_synchronize_uploaders_to_uploaderemails()
+        email_to_delete = email.lower()
+        package.uploaderEmails = [email for email in package.uploaderEmails
+                                  if email.lower() != email_to_delete]
         package.put()
         package.invalidate_cache()
         return handlers.json_success(
             "'%s' is no longer an uploader for package '%s'." %
                 (id, package.name))
+