chrome/installer/util/prebuild/create_string_rc.py - Issue 811283002: [Installer] Cleaning up dead code for App Launcher / App Host installs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/prebuild/create_string_rc.py

Issue 811283002: [Installer] Cleaning up dead code for App Launcher / App Host installs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove query-eula-acceptance; changing ChannelInfo cleanup approach. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/channel_info.h ('K') | « chrome/installer/util/master_preferences_constants.cc ('k') | chrome/installer/util/product.h » ('j') | chrome/installer/util/util_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/prebuild/create_string_rc.py

diff --git a/chrome/installer/util/prebuild/create_string_rc.py b/chrome/installer/util/prebuild/create_string_rc.py

index 96ca2ab15c072a8720b9df1c5c3a6e35d7b5d640..a6b420f11e940f217c5426b8ef99c47f06eff7b4 100755

--- a/chrome/installer/util/prebuild/create_string_rc.py

+++ b/chrome/installer/util/prebuild/create_string_rc.py

@@ -47,13 +47,12 @@ from grit.extern import tclib

STRING_IDS = [

'IDS_PRODUCT_NAME',

'IDS_SXS_SHORTCUT_NAME',

- 'IDS_PRODUCT_APP_LAUNCHER_NAME',

+ 'IDS_PRODUCT_APP_LAUNCHER_NAME', # Used in shadow App Launcher registry.

'IDS_PRODUCT_BINARIES_NAME',

'IDS_PRODUCT_DESCRIPTION',

'IDS_UNINSTALL_CHROME',

'IDS_ABOUT_VERSION_COMPANY_NAME',

'IDS_INSTALL_HIGHER_VERSION',

- 'IDS_INSTALL_HIGHER_VERSION_APP_LAUNCHER',

'IDS_INSTALL_FAILED',

'IDS_SAME_VERSION_REPAIR_FAILED',

'IDS_SETUP_PATCH_FAILED',

@@ -69,9 +68,6 @@ STRING_IDS = [

'IDS_OEM_MAIN_SHORTCUT_NAME',

'IDS_SHORTCUT_TOOLTIP',

'IDS_SHORTCUT_NEW_WINDOW',

- 'IDS_APP_LAUNCHER_PRODUCT_DESCRIPTION',

- 'IDS_APP_LAUNCHER_SHORTCUT_TOOLTIP',

- 'IDS_UNINSTALL_APP_LAUNCHER',

'IDS_APP_LIST_SHORTCUT_NAME',

'IDS_APP_LIST_SHORTCUT_NAME_CANARY',

'IDS_APP_SHORTCUTS_SUBDIR_NAME',