chrome/installer/mini_installer/configuration.h - Issue 811283002: [Installer] Cleaning up dead code for App Launcher / App Host installs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/configuration.h

Issue 811283002: [Installer] Cleaning up dead code for App Launcher / App Host installs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanups; handle ChannelInfo to remove '-apphost' and '-applauncher'. Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/mini_installer/chrome_appid.cc ('k') | chrome/installer/mini_installer/configuration.cc » ('j') | chrome/installer/setup/app_launcher_installer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/mini_installer/configuration.h

diff --git a/chrome/installer/mini_installer/configuration.h b/chrome/installer/mini_installer/configuration.h

index 2e108c7be2b61205a7697b6db5f2d903b5437baf..ba1098f7651f306238506c63a148a4dbcbe5386a 100644

--- a/chrome/installer/mini_installer/configuration.h

+++ b/chrome/installer/mini_installer/configuration.h

@@ -46,9 +46,6 @@ class Configuration {

// Returns true if --chrome-frame is on the command line.

bool has_chrome_frame() const { return has_chrome_frame_; }

- // Returns true if --app-host is on the command line.

- bool has_app_host() const { return has_app_host_; }

// Returns true if --multi-install is on the command line.

bool is_multi_install() const { return is_multi_install_; }

@@ -71,7 +68,6 @@ class Configuration {

Operation operation_;

bool has_chrome_;

bool has_chrome_frame_;

- bool has_app_host_;

bool is_multi_install_;

bool is_system_level_;

bool query_component_build_;